Handle non-uniform C++ st_mtim.tv_sec vs Rust st_mtime#152
Merged
Conversation
Contributor
|
This is ok for now, but ofc it could have been done with rules. Please add a test. |
Contributor
Author
I added a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct statcontains a field calledst_mtime. On Linux, this field is defined as a macro expansion to an internal field:Rust libc does not contain the
st_mtimfield, it only containsst_mtime. To solve this tension, I rewrite all encoutners of::struct stat::st_mtim::tv_secas::libc::stat::st_mtime.I didn't want to touch the converter for this change, but I could not find a solution that only involved rules or the compat layer in
cpp2rust/compat.